Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search page] : Create advanced filters for organizations #933

Merged
merged 10 commits into from
Jul 9, 2024
Merged

[Search page] : Create advanced filters for organizations #933

merged 10 commits into from
Jul 9, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Jul 4, 2024

Description

This PR introduces two new filters for the producer and publisher. It also changes the name of the current filter "Producer" to "Organization", which is more fitting for the fields it filters on.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

Affected libs: feature-router, feature-search, feature-map, feature-dataviz, feature-record,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

📷 Screenshots are here!

@coveralls
Copy link

Coverage Status

coverage: 85.11% (+2.0%) from 83.112%
when pulling 6fcd63c on producer-advanced-filter
into fe59f17 on main.

@coveralls
Copy link

Coverage Status

coverage: 85.11% (+2.0%) from 83.112%
when pulling f2a7369 on producer-advanced-filter
into fe59f17 on main.

@coveralls
Copy link

Coverage Status

coverage: 85.11% (+2.0%) from 83.112%
when pulling a5f26d0 on producer-advanced-filter
into fe59f17 on main.

@cmoinier cmoinier force-pushed the producer-advanced-filter branch from a5f26d0 to 7a9ca71 Compare July 4, 2024 10:50
@coveralls
Copy link

Coverage Status

coverage: 85.11% (+2.0%) from 83.112%
when pulling 7a9ca71 on producer-advanced-filter
into fe59f17 on main.

@jahow jahow added the breaking change Requires an adaptation by the user to keep feature parity label Jul 4, 2024
@jahow
Copy link
Collaborator

jahow commented Jul 4, 2024

This will be a breaking change for both configuration and existing links, to keep in mind for the release :)

@coveralls
Copy link

Coverage Status

coverage: 85.088% (+2.0%) from 83.112%
when pulling b9d69c9 on producer-advanced-filter
into fe59f17 on main.

tkohr
tkohr reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cmoinier ! I've tested it on the MEL use case, where it works as expected 🙂

Don't forget to update the comment in the default.toml regarding the filters and at best even the doc https://geonetwork.github.io/geonetwork-ui/main/docs/guide/configure.html#search ;-)

apps/datahub/src/app/home/search/search-filters/search-filters.component.ts Outdated Show resolved Hide resolved
libs/feature/search/src/lib/utils/service/fields.service.ts Outdated Show resolved Hide resolved
@cmoinier cmoinier force-pushed the producer-advanced-filter branch from b25f849 to 032a2c4 Compare July 5, 2024 13:38
@coveralls
Copy link

Coverage Status

coverage: 85.088% (+1.1%) from 83.973%
when pulling 032a2c4 on producer-advanced-filter
into 9121e5f on main.

@coveralls
Copy link

Coverage Status

coverage: 85.088% (+1.1%) from 83.973%
when pulling dac0dd6 on producer-advanced-filter
into 9121e5f on main.

tkohr
tkohr approved these changes Jul 9, 2024
View reviewed changes
docs/reference/search-fields.md Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 85.088% (+1.1%) from 83.973%
when pulling 0501e19 on producer-advanced-filter
into 9121e5f on main.

@cmoinier cmoinier merged commit cec60ff into main Jul 9, 2024
9 checks passed
@cmoinier cmoinier deleted the producer-advanced-filter branch July 9, 2024 13:55
@cmoinier cmoinier mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkohr tkohr tkohr approved these changes

Assignees
No one assigned
Labels
breaking change Requires an adaptation by the user to keep feature parity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmoinier @coveralls @jahow @tkohr